KaustAbhinand commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6662771495
> [@KaustAbhinand](https://github.com/KaustAbhinand) — thanks for volunteering for `connector-cdc-oracle`. Nobody has claimed it in this thread so far, so it's open for you to look at. > > Before opening a PR, could you post a short scope note here so the slice can be tracked like the others: > > * which factory/factories in `connector-cdc-oracle` you intend to touch (Source vs. Sink) and which option(s)/validation rule(s) you plan to add or tighten in `optionRule()`, > * the `dev` commit you inspected, and whether you searched open/closed PRs for an existing implementation of the same rule, > * the test coverage you plan to add through the existing factory tests (e.g. valid / missing / blank / padded values) and whether the EN/ZH docs need a matching contract update. > > Please keep it to one focused slice and leave unrelated Oracle CDC runtime behavior unchanged. Once the scope note is up we can confirm it here; no assignment change is made yet. Hi @SEZ9! Here is the scope note for **connector-cdc-oracle.** Factories touched: **OracleIncrementalSourceFactory** (Source only — no Sink factory exists in connector-cdc-oracle). One file, optionRule() only; restoreSource() and all runtime classes stay untouched Files changed: **OracleIncrementalSourceFactory.java**, **OracleSourceConfig.java**. **Rule(s) to add/tighten**: migrate the three SCN guards currently enforced at runtime in OracleIncrementalSource.getOracleStartupConfig into optionRule() as ConditionExtensions: **Dev commit inspected**: 914741b9 **Test coverage**: Extended **OracleIncrementalSourceFactoryTest** - with **ConfigValidator** cases — valid (SCN under specific), invalid (SCN under latest/initial/unset mode), invalid (file/pos under specific), plus the existing **testSpecificStartupModeRequiresScn/RejectsInvalidScn** which already pass. **Doc changes**: None required -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
