erica1111-prog commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6499642796
> [@erica1111-prog](https://github.com/erica1111-prog) — as nzw921rx replied, yes, `connector-influxdb` is open for you to look at. > > Before opening a PR, could you post a short scope note here so it can be tracked like the other slices? > > * which part of `connector-influxdb` you intend to touch (Source vs. Sink factory, and which option(s)/validation rule), > * the `dev` commit you inspected, and whether you searched open/closed PRs for an existing implementation of the same rule, > * the test coverage you plan to add through the existing factory tests (e.g. valid / missing / blank / padded values) and whether the EN/ZH docs need a matching contract update. > > Please keep it to one focused slice and leave unrelated InfluxDB runtime behavior unchanged. Once the scope note is up we can confirm it here; no assignment change is made yet. Hi! Here is the scope note for this slice: - **Target slice**: `connector-influxdb` — `InfluxDBSinkFactory`. Migrated `optionRule()` to define the full configuration schema and validation rules for the sink connector: - Required: `URL`, `DATABASES`. - Mutually exclusive options: `KEY_MEASUREMENT_RULE` bundled with optional `KEY_MEASUREMENT_FIELD` vs. standalone `KEY_MEASUREMENT_RULE`. - Optional settings: `USERNAME`, `PASSWORD`, `BATCH_SIZE`, `BATCH_INTERVAL_MS`, `MAX_RETRIES`, `RETRY_BACKOFF_MULTIPLIER_MS`, `CONNECT_TIMEOUT_MS`, `SinkConnectorCommonOptions.MULTI_TABLE_SINK_REPLICA`. - **Inspection & Dedup**: - Inspected on current latest `dev` branch. - Searched both open and closed PRs/Issues for `InfluxDBSinkFactory` and `InfluxDB optionRule`: no existing or duplicate PR implementing `OptionRule` for the InfluxDB sink factory was found. - **Test coverage & Documentation**: - Added test cases in `InfluxDBFactoryTest`: - `testSinkOptionRulesSuccess`: validates successful rule resolution when all mandatory options (`url`, `database`) and valid configurations are provided. - `testSinkOptionRuleMissingRequired`: verifies that validation fails when required options are omitted. - `testSinkOptionRuleMutualExclusion`: verifies conflict handling for mutually exclusive options. - **Docs**: Existing user-facing docs (EN/ZH) already list these options with their types; this migration only enforces the contract at the factory validation level (`OptionRule`), so no doc contract changes are required. All changes are strictly isolated to `InfluxDBSinkFactory` and `InfluxDBFactoryTest` with zero runtime changes to the InfluxDB sink execution logic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
