PHJ2000 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6468228177
Yes, I would like to contribute to Apache SeaTunnel with a focused MaxCompute **Sink `endpoint` validation** slice for #11007. I inspected `dev` at `0145209931a4fe6795bbcf64a827f0f75302a624`: `MaxcomputeSourceFactory` already applies `Conditions.notBlank(ENDPOINT)` from #12690, while `MaxcomputeSinkFactory` requires `endpoint` only for presence. This is a source inspection; I have not run a regression test or changed code yet. The proposed scope is a nonblank condition on the existing required sink endpoint, extending the existing factory tests through `ConfigValidator` for valid, missing, empty, whitespace-only and padded nonblank values. Nonblank values would remain unchanged. I would retain `project`/`table_name` requirements, source rules, credential fallback, timeout/retry defaults and bounds, URL parsing, client construction and all runtime checks. The change would include the corresponding EN/ZH sink documentation and configuration-check coverage in the existing MaxCompute E2E suite. I would report base/head regression results, module tests, Spotless, verification and the actual E2E execution limits separately. #11586 is still open and changes the same sink factory, shared factory test and sink docs for retry validation. I found no endpoint-specific sink PR in the open/closed title searches, but would like to avoid conflicting work. Is this endpoint slice available after #11586 merges, or would you prefer coordination with its author first? I will wait for scope/ownership confirmation before implementation. <!-- contribution-flow:apache--seatunnel--11007:maxcompute-sink-claim-v1 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
