Vivek1106-04 commented on PR #12623: URL: https://github.com/apache/seatunnel/pull/12623#issuecomment-6702779767
@SEZ9 @DanielLeens **F2.** I consider a `SubPlan`-level test out of scope for this PR and do not plan to add one here. The whole-job scenario in #12622 (pipeline in restore wait, `forceStopPipeline()`, job leaving `DOING_SAVEPOINT`) is covered by `SavePointTest#testSavePointFailureDuringPipelineRestoreWaitEndsTheJob` and `CheckpointErrorRestoreEndTest#testCancelDuringPipelineRestoreWaitEndsTheJobCanceled` in #12511. Once #12511 is in, a test of that scenario here would stop at #12511's re-check and would pass with or without this fix, so it would not add evidence for this change. I added a "Scope of the evidence" paragraph to the PR description. It says the tests here are vertex-level, that they do not prove the full #12622 scenario, and that #12622 is only fully addressed once both PRs have landed. I also refreshed the test section, which still listed 6 tests in `StateTransitionCleanupTest` from `f24ed531e`; it now records the 20 at this head and the revert result. **F1.** No change: please re-check it after #12511 merges. This is a description-only update. The head is unchanged at `caa5f098f`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
