SEZ9 commented on PR #12623: URL: https://github.com/apache/seatunnel/pull/12623#issuecomment-6620832076
Thanks for running the revert check, @Vivek1106-04. **F2.** The mutation run is useful evidence: with `PhysicalVertex.java` reset to its `dev` version and the test file unchanged, `testForceStopCompletesTheFutureOfATaskWhoseStateProcessIsStopped` and `testForceStopCompletesTheFutureOfATaskResetForRestore` time out at the `taskFuture.get(10, TimeUnit.SECONDS)` calls after `physicalVertex.forceStop()`, while the control run with the PR's version passes all 20. That shows the existing vertex-level tests do distinguish the fix from the old behavior. However, F2 was about scope: the test exercises a bare vertex in CREATED with no SubPlan or JobMaster and does not cover the #12622 scenario (pipeline in restore wait, `forceStopPipeline()`, job leaving `DOING_SAVEPOINT`). Since the head is unchanged at `caa5f098f` and the test's scope has not changed, I'm keeping F2 open for now. Could you let me know whether you plan to add a SubPlan-level test for that scenario in this PR, or whether you consider it out of scope here? If the latter, a sh ort note in the PR description would help. **F1.** The merge-order line at the top of the description (#12511 must land first) is what I asked for. F1 stays open until #12511 merges; I'll re-check it then. No need to push the revert. <!-- streview-comment:2256 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
