SEZ9 commented on PR #11814:
URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-6817018444

   @goutamadwant thanks for the point-by-point walkthrough, and sorry for the 
delayed reply.
   
   On F1–F6, your explanations line up with what I was after:
   
   - **F1** – If `executeExtraCommands(server)` runs before `server.start()` in 
`createSeaTunnelServer`, the wait strategy set in the hook does gate readiness, 
and the config copy in the same hook relying on that order is a good 
confirmation.
   - **F2** – Running the final flush only when the scheduler terminated and 
the thread wasn't interrupted, plus cancelling in-flight calls before 
`evictAll()` in `finally`, is what I was looking for.
   - **F3** – Catching `Exception` on both flush paths and restoring the 
interrupt flag, with test coverage in `JobEventHttpReportHandlerTest`, 
addresses the concern.
   - **F4** – Importing `kotlin-bom` 1.9.10 in 
`seatunnel-engine-server/pom.xml` resolves the mixed stdlib graph, and your 
11-07 note that the runtime Kotlin libraries still resolve to 1.9.10 through 
the BOM after the `dev` merge is good to have on record.
   - **F5** – Explicit `report()` call, 10s bound on `takeRequest`, and closing 
the buffers covers all three parts.
   - **F6** – Thanks for aligning the Kubernetes block in 
`release-docs/LICENSE` to 1.9.10 in `fbd73878d6`; with `known-dependencies.txt` 
already at 1.9.10 only, the inventories should now match.
   
   I'll confirm each of these against the diff on the current head `06a7b0ac` 
and resolve them once verified.
   
   Your comment looks like it was cut off after F6, so two items are still open:
   
   - **F7** – Does the new `OkHttpClient` still follow redirects by default? If 
so, please either disable that or explain why forwarding the configured report 
headers to a redirect target on another host is acceptable here.
   - **F8** – Can you confirm whether the `Content-Type` header produced by 
`RequestBody.create(String, MediaType)` stays byte-identical to the previous 
implementation when the configured media type has no charset? If it changes, a 
short note in the PR description for existing collector users would be enough.
   
   Once F7 and F8 have a reply I'm happy to approve.
   
   <!-- streview-comment:2282 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to