SEZ9 commented on PR #11814:
URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-6889159189

   Thanks for the follow-up. A quick status on the open points:
   
   **Merge state.** Head `06a7b0ac4f416252b4234dd4f8af48d0e9f3b414` is reported 
as conflicting with `dev`, even though the 
[Build](https://github.com/apache/seatunnel/runs/128488973591) is green for 
that commit. Could you resolve the conflict against the latest `dev` and push, 
so the checks run on the resolved head?
   
   **F7 / F8.** For F8, could you point me at the assertion (or diff) that pins 
the `Content-Type` wire behavior when the configured media type has no charset? 
A short comment next to it stating the intent would also help keep it from 
being removed later. For F7, could you confirm whether the `OkHttpClient` is 
built with redirects disabled, or explain why forwarding the configured report 
headers on redirect is acceptable?
   
   **F1–F6.** I don't see changes for these on the current head, so a short 
per-item status would help:
   - F1: making the `received new worker register` wait strategy actually gate 
container startup instead of running in `executeExtraCommands`.
   - F2 / F3: `close()` behavior when the scheduler doesn't terminate — 
guarding the local-buffer flush against the still-running task, and handling 
failures other than `HazelcastInstanceNotActiveException`/`IOException` so they 
don't escape `close()`.
   - F4 / F6: aligning the Kotlin stdlib versions (1.8.21 vs 1.9.10) in the 
dependency and license inventories, and confirming they match what the dist 
actually resolves.
   - F5: a bounded `takeRequest()` in `testRetryAfterHttpFailure`, closing the 
request `Buffer`s, and triggering the scheduler explicitly rather than relying 
on it firing under a 1-day interval.
   
   If any of these are already handled, just point me at the change and I'll 
verify on the new head. Otherwise, happy to review them in a follow-up commit 
on this PR.
   
   <!-- streview-comment:2367 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to