SEZ9 commented on PR #11814:
URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-6870293426

   Thanks for the follow-up on the two low-severity items.
   
   **F7 (redirects):** The pointer to `createHttpClient` with 
`.followRedirects(false)` / `.followSslRedirects(false)`, plus 
`testDoesNotFollowRedirects` covering a 307 with an Authorization header and 
asserting the redirect target receives nothing, is the evidence I was after. 
I'll confirm it on head `06a7b0ac4f416252b4234dd4f8af48d0e9f3b414` and then 
resolve F7.
   
   **F8 (Content-Type charset suffix):** Understood that both the previous and 
the new `RequestBody.create` paths append `; charset=utf-8` for 
`application/json` without a charset, and that the regression assertion pins 
`application/json; charset=utf-8`. Since this was a source comparison rather 
than an old/new wire capture, I'll verify the behaviour on the same head before 
resolving F8. One small ask: please add a one-line comment next to that 
assertion noting the charset suffix is pre-existing behaviour, so nobody later 
"fixes" the test in the wrong direction.
   
   **Still open:** I haven't seen a response yet on F1–F6:
   - F1 – the `received new worker register` wait strategy being set from 
`executeExtraCommands`, after the container lifecycle is already configured.
   - F2/F3 – `close()` behaviour when the scheduler doesn't terminate 
(concurrent flush with the in-flight task, `evictAll()` not reclaiming 
in-flight connections, and blocking flush on a possibly-interrupted thread with 
only `HazelcastInstanceNotActiveException`/`IOException` caught).
   - F4/F6 – the mixed kotlin-stdlib 1.8.21 / kotlin-stdlib-common 1.9.10 graph 
in the dependency and license inventories; please confirm what the dist 
actually resolves to and whether you can align/pin them.
   - F5 – `testRetryAfterHttpFailure`: no-timeout `takeRequest()`, leaked 
request `Buffer`s, and the assumption that the scheduler fires immediately 
despite the 1-day interval.
   
   Either a fix or a short rationale for each is fine. Please ping me once a 
new head is pushed so I can do a final pass.
   
   <!-- streview-comment:2331 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to