SEZ9 commented on PR #12397:
URL: https://github.com/apache/seatunnel/pull/12397#issuecomment-6817165067

   Thanks @goutamadwant for the point-by-point mapping, and sorry for the slow 
reply. What you describe matches what I asked for on all six points: the 
`ArrayStoreException` wrapping in `SeaTunnelArrayType.setElement` with index, 
declared type and expected/actual class (field/table name is fine to leave 
out), the documented and tested lossy TIME/TIMESTAMP_TZ array mapping, the 
`SeaTunnelArrayType` Javadoc and pointer to the parser `MapType.class` defect 
(keeping the name is fine with me), the `runtimeClass` comment covering both 
the parsed array-of-map case and the `LocalTimeType[]` constants, the module 
path and NPE failure mode in `incompatible-changes.md`, and the trimmed Nested 
Arrays section in `spark.md`.
   
   I still need to confirm these against the actual diff rather than the 
description, and I see the head has moved from `d289489598` to `e0b768d5`. 
Could you confirm that the PR's own changes are unchanged between `d2894895` 
and `e0b768d5`, and share the current CI status on `e0b768d5` (including 
whether fork run 42402015442 is fully green)? Once I've gone through the diff 
on that head and CI is green, I'll approve.
   
   <!-- streview-comment:2284 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to