Rangsh commented on PR #12081:
URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-6822893233

   Yes, @SEZ9, both `get` variants already have method-level Javadoc for the 
new contract on `ef99d22d1`, so no further note is needed.
   
   - **Untimed `get()`:** stays for the `Future` contract and is no longer an 
unbounded wait. It delegates to the timed `get` using the configured 
`writDataTimeoutMilliseconds` (the private field name is missing the `e`; the 
public config key is `writeDataTimeoutMilliseconds`), and a timeout throws: 
[`RequestFuture.java` 
L84-L108](https://github.com/apache/seatunnel/blob/ef99d22d1afec8dc6ce094636a3eeb26910cdd03/seatunnel-engine/seatunnel-engine-storage/imap-storage-plugins/imap-storage-file/src/main/java/org/apache/seatunnel/engine/imap/storage/file/future/RequestFuture.java#L84-L108).
   - **Timed `get(timeout, unit)`:** throws `TimeoutException` instead of 
returning `false`: [`RequestFuture.java` 
L110-L130](https://github.com/apache/seatunnel/blob/ef99d22d1afec8dc6ce094636a3eeb26910cdd03/seatunnel-engine/seatunnel-engine-storage/imap-storage-plugins/imap-storage-file/src/main/java/org/apache/seatunnel/engine/imap/storage/file/future/RequestFuture.java#L110-L130).
   
   The PR description already has the one-line mention: timed 
`RequestFuture.get` throws `TimeoutException` on expiry instead of silently 
returning `false`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to