SEZ9 commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-6816802608
@Rangsh thanks for the walkthrough on `ef99d22d1`, and sorry for the slow turnaround. **F1.** Agreed that the untimed `get()` has to stay for the `Future` contract; delegating to the timed `get` with the configured timeout (`RequestFuture.java` L84-L108) is the approach I was hoping for. **F2 / F4.** Thanks for the `WALWorkHandler.java` pointers (L95-L140 and L57-L72). **F5 / F6 / F8.** I also see the head locations already posted in this thread (module `pom.xml:81-90` for the test-scoped Mockito dependency, `IMapFileStorage:394-417` for the single batch deadline, and `:378-385` / `:418-428` for DEBUG-level timeout traces), so no need to repeat those. **F3 / F7.** One remaining question: with the untimed `get()` now bounded by the configured timeout instead of the old 1-second cap, and the timed `get` throwing `TimeoutException` instead of returning `false`, do both `get` variants carry method-level Javadoc describing the new contract? If not, a short note there plus a one-line mention in the PR description would be enough. I'll go through everything on `ef99d22d1afec8dc6ce094636a3eeb26910cdd03` and resolve the threads once the F3/F7 question is settled. <!-- streview-comment:2279 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
