DanielLeens commented on PR #13070:
URL: https://github.com/apache/seatunnel/pull/13070#issuecomment-6879514697

   ### Implementation Notes and Trade-offs
   
   Yes, contributing to Apache SeaTunnel. Follow-up on head 
`bb834e5f18d06edc0b0568fe16d54767b90c122f`.
   
   The MySQL 5.x smoke tests could wait for CDC rows with binary logging 
disabled because the version-specific resource was not loaded as my.cnf. The 
correction keeps the server settings and DML assertions and checks the live 
server log_bin, binlog_format and GTID variables before CDC starts. Only the 
test fixture is changed; production runtime and driver dependencies are 
unchanged.
   
   The Java test changes passed Spotless with the repository rules and version. 
The staged diff passed the whitespace check and received independent source 
review. No local functional tests or UI were run. The applicable GitHub CI must 
run on this head.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to