SEZ9 commented on PR #12678:
URL: https://github.com/apache/seatunnel/pull/12678#issuecomment-6888096538

   Thanks for the clear local results, @kalayciburak 
(`CheckpointCoordinatorTest` 18 passed and 
`CheckpointStorageRetentionPruneTest` 1 passed at `71ac656652f0`, Java 17, 
`package` phase), and for distinguishing them from GitHub evidence.
   
   On the source side, nothing changes from my [previous 
review](https://github.com/apache/seatunnel/pull/12678#pullrequestreview-5681302082):
 the PR files at `71ac656652f0` are byte-identical to `09d530be2df6`, so that 
conclusion still stands for the reviewed scope and I am not asking for further 
source changes. One question, not a blocker: does 
`CheckpointStorageRetentionPruneTest` cover the storage-failure branch of 
`pruneExcessCompletedCheckpoints` (ids re-queued, checkpoint still completes), 
or only the happy path? A pointer is enough.
   
   On CI: the [Build](https://github.com/apache/seatunnel/runs/122810327224) 
for `71ac656652f0fa3423067dc6ee1052b3b3be844a` is still `ACTION_REQUIRED`, 
meaning no fork Build run was found for this SHA. Local runs can't stand in for 
it, so once an exact-head Build run exists (fork Actions enabled and the 
existing Build workflow dispatched for this branch, or a run in another 
repository you control), please link it here. As you said, no rebase is needed 
in the meantime.
   
   <!-- streview-comment:2357 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to