SEZ9 commented on PR #12678: URL: https://github.com/apache/seatunnel/pull/12678#issuecomment-6459609745
Thanks for the update, @kalayciburak. On the two open points from my earlier round: **F1 (ids popped before `deleteCheckpoint`, failure fails the checkpoint / orphans files, runs on every completion)** — On the current head `09d530be2df6` the helper now catches `Exception`, pushes the popped ids back onto the deque with a WARN, and the retry test covers an unchecked delete failure. That addresses the orphaning and the "cleanup failure fails the checkpoint" part. Recording the per-completion listing trade-off in the PR description is fine with me; I'm treating that as an accepted cost rather than a blocker. **F2 (`completedCheckpointIds` not seeded on restore)** — Keeping restore seeding out of this PR and documenting the limitation plus the follow-up in the PR description works for the scope here. One small remaining ask: your last comment references `21cfc050`, but the current PR head is `09d530be2df6` (the branch moved on from `551187b8`). Could you confirm `09d530be2df6` is the commit you intended? Once that's confirmed I have nothing further on these two findings. <!-- streview-comment:2088 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
