SEZ9 commented on PR #12327: URL: https://github.com/apache/seatunnel/pull/12327#issuecomment-6905328664
Thanks for the detailed follow-up, @Dev-next-gen. The approach you describe in 4be680c2e sounds right to me: - Unterminated quote (F1/F2): throwing `IllegalArgumentException` after the loop is the fail-fast behaviour I was after; a loud error beats a DDL with duplicated columns. - Backslash scope (F3): limiting the escape to single- and double-quoted literals and leaving backticks alone addresses the desync I described. - Tests (F4/F5): the offset check for a bare `creator` after a quoted literal, the double-quote / `''` / backtick cases, the unterminated-quote case, and running the same test class against the MaxCompute copy are the gaps I had in mind. - Javadoc (F7): good, thanks. - Deduplication (F6): deferring to a follow-up is fine. Please open that follow-up (or note it in the PR description) so the three copies don't stay in lockstep forever. I'll take a look at the diff for 4be680c2e to confirm the above before marking these resolved. <!-- streview-comment:2373 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
