SEZ9 commented on PR #12327: URL: https://github.com/apache/seatunnel/pull/12327#issuecomment-6935672130
@Dev-next-gen thanks for adding the deduplication follow-up to the PR description. That settles the deduplication point for this PR: pointing `MaxComputeCatalogUtil` at the `connector-common` parser and deleting the ClickHouse copy can land separately, and no further code change is needed here for it. One question on that follow-up: will you open it yourself, or should it be tracked somewhere beyond the PR description? The description is easy to lose track of after merge, and until the copies are removed they still have to be patched in lockstep. On the other points, your description of 4be680c2e covers what was raised: - **Unterminated or unbalanced quote:** it now throws `IllegalArgumentException: Unterminated ' quote in save_mode_create_template` instead of returning a partial map. Having the `-- don't touch this` template fail loudly, rather than silently return `[id]`, is the behaviour I was asking for. - **Backslash in backtick identifiers:** the backslash escape now applies only inside single-quoted and double-quoted literals. - **Javadoc:** `getColumnList` now documents the quote rules, the unterminated case and what the offsets mean. - **Tests:** the new cases cover a double-quoted literal, a doubled single quote, a backtick identifier containing a comma, a backslash before a closing backtick, the offsets of `creator` after an escaped quote, and the unterminated quote. The same test class also runs against the MaxCompute copy. I have no further change requests on these. I'll go through 4be680c2e itself to confirm. <!-- streview-comment:2382 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
