Dev-next-gen commented on PR #12327:
URL: https://github.com/apache/seatunnel/pull/12327#issuecomment-6991922938

   @DanielLeens you were right about the comment case: with `` `id` BIGINT NOT 
NULL -- don't change this type `` and the comma on the next line, 4be680c2e 
opened a quote on the apostrophe and threw at EOF, while the dev parser 
accepted it. I pushed 64a5084e4. Outside quoted text the scanner now treats `-- 
...` to the end of the line and `/* ... */` as opaque, appending them verbatim 
so offsets are unchanged 
([`CreateTableParser.java:70-82`](https://github.com/apache/seatunnel/blob/64a5084e409e4a9248d7985de5e07420f18f3222/seatunnel-connectors-v2/connector-common/src/main/java/org/apache/seatunnel/connectors/seatunnel/common/util/CreateTableParser.java#L70-L82)),
 and an unclosed `/*` fails like an unclosed quote. The Javadoc now also says 
that parentheses inside a column are tracked one level deep only. 
`DorisCreateTableTest.testQuoteInsideSqlCommentOfTemplate` runs your case 
through `DorisCatalogUtil.getCreateTableStatement` with a bare `name` after it, 
and passes on the dev parser an
 d on this head. The new `testQuotesInsideSqlCommentsAreIgnored` (both 
`CreateTableParserTest` copies) fails on 4be680c2e and passes here. On JDK 17: 
connector-doris 161/161, connector-maxcompute 102/102, connector-common and 
connector-clickhouse BUILD SUCCESS, `spotless:check` clean. I can't link a 
Build for this head: `gh workflow run build_main.yml` on Dev-next-gen/seatunnel 
returns `HTTP 422: Actions has been disabled for this repository`.
   
   @SEZ9 the comment is complete on GitHub. Point 3 goes on with 
`testDoubleQuotesBackticksAndDoubledQuotes` (`"low,medium)"`, `'it''s, a'`, `` 
`p,q` ``, `` `path\` `` then a bare column and its offsets) and 
`testUnterminatedQuoteFails`. The MaxCompute `CreateTableParserTest` has the 
same tests. Point 4 is the Javadoc on `getColumnList`. On drift: in this commit 
the MaxCompute and ClickHouse copies were regenerated from the connector-common 
one, and `diff` between them shows only the `package` line. The two live copies 
run the same four-test class. The removal itself is still tracked in #13290 and 
is not in this PR.
   
   Found by a defect-hunting pipeline I build and run 
([Dev-next-gen](https://github.com/Dev-next-gen)), using Claude Code with 
Anthropic's Claude Opus 5.5.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to