Eymenonar commented on PR #12853:
URL: https://github.com/apache/seatunnel/pull/12853#issuecomment-6983312835

   @SEZ9 yes, all three are covered on 
`e6985779d2c212f802774aa93840787f3d518a5f`:
   
   1. The incompatible-changes entry explicitly names Spark schema translation 
and Iceberg table creation, with a cast to precision <=38 before schema 
translation as the migration path: 
[EN](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/docs/en/introduction/concepts/incompatible-changes.md#L148-L164),
 
[ZH](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/docs/zh/introduction/concepts/incompatible-changes.md#L137-L145).
   2. The MySQL mapping tables use the same `(p,s)` for signed and unsigned 
DECIMAL, capped at 65/30: [EN 
source](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/docs/en/connectors/source/Mysql.md#L59),
 [EN 
sink](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/docs/en/connectors/sink/Mysql.md#L58),
 [ZH 
source](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/docs/zh/connectors/source/Mysql.md#L59),
 [ZH 
sink](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/docs/zh/connectors/sink/Mysql.md#L58).
 Small commit-history clarification: the table changes are in the main fix, now 
`e02698b15`; `7a3c7991` only added the MySQL-CDC mention and `825f69f9` added 
blank lines. Both converters cap scale at 30, including after reducing it for 
excess precision, and compute `adjustedScale` once.
   3. `testConvertDecimalClampsPrecisionAndScale` exists in both 
[MySqlTypeConverterTest](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/mysql/MySqlTypeConverterTest.java#L552-L592)
 and 
[OceanBaseMySqlTypeConverterTest](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oceanbase/OceanBaseMySqlTypeConverterTest.java#L156-L183).
 Each asserts `(70,10) -> (65,5)` and `(50,40) -> (50,30)`; the MySQL test also 
asserts `(70,3) -> (65,0)`.
   
   No code change was needed for these confirmations. CI on this head is still 
unverified; these links are source/test assertions, not a claim that the 
required Build has passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to