SEZ9 commented on PR #12853: URL: https://github.com/apache/seatunnel/pull/12853#issuecomment-7023304663
@Eymenonar thanks for the detailed explanation and the links on `e6985779`. - **OceanBase unsigned rule:** Noted that OceanBase no longer adds `p + 1`, that signed and unsigned DECIMAL share the same `(p,s)` branch, matching MySQL, and that the unsigned test asserts `DECIMAL(65,0) UNSIGNED -> DecimalType(65,0)` with column length 65 and scale 0. As you describe it, that covers both the unsigned rule and the old narrowing above precision 38, so the two dialects should no longer yield different schemas for the same table. - **Row test:** Noted the rename to `testWideDecimalValueIsReadAndWrittenWithoutNarrowing`, the 65-digit literal, and the checks on both `getBigDecimal` and `setBigDecimal` through JDBC mocks. Agreed on the scope: this test guards value preservation, and the converter tests guard the precision mapping. I am going by your description here rather than a new run of my own, and I have no further questions on these two points. <!-- streview-comment:2460 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
