Eymenonar commented on PR #12853:
URL: https://github.com/apache/seatunnel/pull/12853#issuecomment-7003616651

   @SEZ9 yes, both are already addressed on `e6985779`:
   
   - OceanBase no longer adds `p + 1`. Its signed and unsigned DECIMAL cases 
share the same [(p,s) 
branch](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oceanbase/OceanBaseMySqlTypeConverter.java#L191-L229),
 matching MySQL. The [unsigned 
test](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oceanbase/OceanBaseMySqlTypeConverterTest.java#L142-L153)
 asserts `DECIMAL(65,0) UNSIGNED -> DecimalType(65,0)`, with column length 65 
and scale 0.
   - The row test was renamed to 
[`testWideDecimalValueIsReadAndWrittenWithoutNarrowing`](https://github.com/apache/seatunnel/blob/e6985779d2c212f802774aa93840787f3d518a5f/seatunnel-connectors-v2/connector-jdbc/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/mysql/MysqlJdbcRowConverterTest.java#L178-L202).
 It now uses a 65-digit literal and checks both `getBigDecimal` and 
`setBigDecimal` through JDBC mocks. You're right about its scope: it guards 
value preservation, not precision mapping. The converter tests guard the 
mapping regression.
   
   I rechecked CI: there are still no checks or fork workflow runs for this 
head, so there's no Build result to link yet. No new code change was needed for 
these confirmations.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to