SEZ9 commented on issue #12809:
URL: https://github.com/apache/seatunnel/issues/12809#issuecomment-6991972843

   Thanks @niumy0701, here is where the earlier asks stand based on your update.
   
   **Done**
   - **TextChunk PR link:** #13270 is now linked here, covering both the EN and 
ZH `text-chunk.md` pages as a documentation-only change against `dev`.
   - **Verification source:** you state the options were verified against 
`TextChunkTransformConfig` and `TextChunkTransformFactory#optionRule()`.
   - **Language parity:** you state the multi-table options and the conditional 
`text_field` / `chunk_size` / `overlap_size` validation semantics are described 
identically in both languages.
   - **Build:** you report a passing fork build on the latest head (run 
`44071152209`).
   
   **Still open**
   - **Key-column restrictions:** your update does not mention the restrictions 
on `output_field` / `chunk_index_field`. Please confirm both languages describe 
them the same way in #13270.
   - **PR description:** please confirm the description of #13270 itself names 
the config and factory classes, so the reviewer can check both languages 
against the same rule without coming back to this thread.
   - **DataValidator:** please post that PR link here once it is submitted. The 
earlier asks still apply: name the verified classes in the description, and 
keep the `row_error_handle_way` multi-table description the same in both 
languages.
   
   On your request for a look at #13270: I can't confirm from this tracker 
thread that it has no remaining blocking issues. That is decided in the 
detailed review on the PR itself, and this issue only needs to track the claim 
and the links.
   
   <!-- streview-comment:2428 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to