niumy0701 commented on issue #12809: URL: https://github.com/apache/seatunnel/issues/12809#issuecomment-6967855350
> Thanks [@niumy0701](https://github.com/niumy0701), your claim for the **TextChunk** and **DataValidator** documentation rewrites is noted. Two separate PRs, one plugin each with EN and ZH kept in sync, works well for this tracker. > > Your pre-checks cover what a reviewer will need: > > * **TextChunk:** `TextChunkTransformConfig` and `TextChunkTransformFactory#optionRule()`, including the multi-table options and the validation semantics you listed. > * **DataValidator:** `DataValidatorTransformConfig` and `DataValidatorTransformFactory#optionRule()`, including the multi-table semantics of `row_error_handle_way`. > * **Overlap:** your check that no open documentation PR modifies these four files. > > Remaining asks: > > * Please post the TextChunk PR link here once it is submitted, and the DataValidator link when that one follows. Neither is linked in this thread yet. > * In each PR description, please state which config and factory classes the option table was verified against, so the reviewer can check both languages against the same rule. > * For TextChunk, please make sure both languages describe the conditional `text_field` requirement, `chunk_size > 0`, `0 <= overlap_size < chunk_size`, and the key-column restrictions on `output_field` / `chunk_index_field` the same way. > * For DataValidator, please make sure the `row_error_handle_way` multi-table description reads the same in both languages. > > Detailed review can then happen on the individual PRs. The TextChunk rewrite is submitted in #13270 (docs/en/transforms/text-chunk.md + docs/zh/transforms/text-chunk.md, documentation-only against dev), with options verified against TextChunkTransformConfig and TextChunkTransformFactory#optionRule() as listed in the claim. The multi-table options and the conditional text_field / chunk_size / overlap_size validation semantics are described identically in both languages, and all feedback from @DanielLeens has been addressed across 4 review rounds. A fork Build passes on the latest head: https://github.com/niumy0701/seatunnel/actions/runs/44071152209 cc @SEZ9 — it has no remaining blocking issues. Could you help take a look when you have time? The DataValidator PR will follow separately, as discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
