CryoThrust commented on PR #12101:
URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-6998859420

   The cancelled Build is not a pass; I will keep the next run separate from 
the older green result.
   
   I rechecked the failure path against the current head. The production change 
is already in `ce93a3a44`: `validateConfig()` can throw `ConfigCheckException`, 
but JSON mode calls it through `validateResult()`, which catches validation 
exceptions and returns the failure model. `executeForExitCode()` prints that 
model once and returns 1. `SeaTunnelClient.main()` uses that status directly 
instead of invoking `SeaTunnel.run()` and its text-mode exception logging. Text 
mode still takes the existing exception path. The Bash launcher sets 
`seatunnel.console.target=SYSTEM_ERR` before Java starts; the supplied Log4j 
client config uses that target for diagnostics.
   
   The prior launcher test exercised a missing file, which fails before the 
config validation block. I have now extended the same test with an existing 
file containing an invalid `job.mode`, so it exercises the internal 
`ConfigCheckException` path as well. The real Zeta/Bash container run passes: 
success exits 0; both missing-file and invalid-value failures exit 1; each 
stdout is exactly one complete JSON value with trailing-token rejection. For 
the invalid value, the JSON contains a sanitized message, stderr contains 
diagnostics without the text-mode error banner, and neither stream exposes the 
dummy password. The same file in text mode retains its sanitized failure 
diagnostic.
   
   This follow-up changes only the existing integration test, with no 
additional production fix claimed. Scoped Spotless, E2E-module skip-tests 
`verify` and whitespace checks pass. Native Windows and arbitrary custom 
logging configurations remain outside this launcher test; the documented stderr 
configuration requirement still applies there.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to