SEZ9 commented on PR #12101:
URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-6937137992

   @CryoThrust thanks for the point-by-point mapping on `ce93a3a44`; it makes 
the follow-up easy to track.
   
   Your description explains the intent, but I have not yet checked it against 
the changed code, so I am not marking any of the previous findings resolved 
yet. A few points need clarification in the meantime:
   
   1. **F1 (text mode):** you note that the default static text-mode cause 
behavior is retained. The original concern was that the unsanitized exception 
is re-attached as the cause of the thrown `ConfigCheckException`, which defeats 
the sanitization. If the text-mode path still carries the unsanitized cause, 
this finding is still open. Please either sanitize or drop the cause there, or 
explain why the cause chain cannot expose credentials in text mode.
   
   2. **F3:** does the fallback for missing exception messages also apply to 
the `ConfigCheckException` thrown in text mode, or only to the JSON result? The 
original finding was that the null guard protected only the JSON payload. If a 
test exercises a null-message exception, please point to it; if not, please add 
one.
   
   3. **F4:** the launcher change and the container result you describe are 
local results that I still need to confirm against the code. Since native 
Windows launcher execution was not tested, please make sure the documentation 
is explicit about which launchers the JSON-only stdout behavior was verified on.
   
   4. **F8:** you mention that the argument-validation expression already 
groups the mixed boolean conditions explicitly. That reads as disagreement with 
that part of the finding rather than a change. Could you point to the 
expression you mean so I can re-check it?
   
   For **F2, F5, F6 and F7**, your description matches what was asked. They 
stay open until I have confirmed them against the code.
   
   <!-- streview-comment:2398 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to