CryoThrust commented on PR #12101: URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-6917842665
Pushed `ce93a3a44` after syncing `dev` at `37309e1a8`, including #13203. No SFTP-specific patch or backpressure-test change was added. Mapping the review findings to the current implementation: - **F1/F3:** the JSON adapter consumes a sanitized result and returns an exit status without propagating a validation exception to the launcher. Missing exception messages receive a fallback before sanitization. Default static text-mode cause behavior is retained. - **F2:** `ConfigValidationResult.toJson()` uses Jackson object/array nodes. The existing quote, newline and control-character round-trip test passes. - **F4:** `SeaTunnelClient` uses the explicit JSON exit status instead of `SeaTunnel.run`'s text-error logger. The Bash launcher sets the supplied logging configuration's console target to stderr before JVM startup. Other launchers/custom logging requirements are documented. - **F5:** `FileUtils.getConfigPath()` is outside the text validation catch again; a regression asserts that its original exception instance is preserved. - **F6:** JSON serialization is performed after `validateResult()` returns, outside validation error handling. - **F7:** both command guides describe `schemaVersion`, `valid`, `phase`, `errors` and error-entry fields. - **F8:** one result-emission path replaces the duplicated failure blocks. The argument-validation expression already groups the mixed boolean conditions explicitly. JDK 11 verification: 65 starter/argument/launcher tests and three schema tests pass without skips. The actual Zeta container test also passes: one JSON document on stdout for success/failure, exit codes 0/1, and no text configuration-error banner on failure. Scoped formatting, dependency-reactor verification and final starter/E2E-module verification pass. Native Windows launcher execution was not tested locally. The earlier engine backpressure failure remains a separate CI gate; these local results do not establish that it is fixed. I will keep any recurrence visible in the new-head Build result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
