tianxiaoliang commented on a change in pull request #722:
URL:
https://github.com/apache/servicecomb-service-center/pull/722#discussion_r512465184
##########
File path: datasource/engine.go
##########
@@ -14,23 +14,21 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package util
+
+package datasource
import (
"context"
- "testing"
+ "github.com/apache/servicecomb-service-center/pkg/types"
+ "time"
)
-func TestAddTagIntoETCD(t *testing.T) {
- err := AddTagIntoETCD(context.Background(), "", "",
map[string]string{"a": "1"})
- if err == nil {
- t.Fatalf(`AddTagIntoETCD with {"a": "1"} tags failed`)
- }
-}
-
-func TestGetTagsUtils(t *testing.T) {
- _, err := GetTagsUtils(context.Background(), "", "")
- if err != nil {
- t.Fatalf(`GetTagsUtils failed`)
- }
+// SCManager contains the APIs of registration of SC itself
Review comment:
参考eureka的机制，他其实使用eureka
client进行自注册，注销，心跳，所以这种内部注册的方式相对eureka解决了什么不能解决的问题么，是否可以用eureka这种简单明了，节省代码的方式搞定
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
