tianxiaoliang commented on a change in pull request #722: URL: https://github.com/apache/servicecomb-service-center/pull/722#discussion_r512487654
########## File path: datasource/etcd/kv/kv.go ########## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package kv Review comment: 通过包注释简单阐述下主要职责和设计吧 ########## File path: datasource/etcd/sd/aggregate/common.go ########## @@ -43,8 +43,8 @@ func init() { repos = strings.Split(modes, ",") log.Infof("aggregate_mode is %s", repos) - // here save the index if found the registry plugin in modes list, - // it is used for getting the one writable registry to handle requests + // here save the index if found the cache plugin in modes list, Review comment: 注释错了 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
