tianxiaoliang commented on a change in pull request #722:
URL:
https://github.com/apache/servicecomb-service-center/pull/722#discussion_r512492195
##########
File path: datasource/etcd/sd/cache_kv.go
##########
@@ -23,7 +23,7 @@ import (
)
// KvCache implements Cache.
-// KvCache is dedicated to stores service discovery data,
+// KvCache is dedicated to stores service pkg data,
Review comment:
注释错了
##########
File path: datasource/etcd/sd/discovery.go
##########
@@ -14,16 +14,16 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package discovery
+package sd
-// Adaptor is used to do service discovery.
+// Adaptor is used to do service pkg.
// To improve the performance, Adaptor may use cache firstly in
-// service discovery.
+// service pkg.
type Adaptor interface {
Runnable
- // Indexer is used to search data from the registry.
+ // Indexer is used to search data from the cache.
Indexer
- // Cacher is used to manage the registry's cache.
+ // Cacher is used to manage the cache's cache.
Review comment:
注释错了
##########
File path: datasource/etcd/sd/cacher.go
##########
@@ -22,8 +24,8 @@ import (
"github.com/apache/servicecomb-service-center/pkg/util"
)
-// CommonCacher implements discovery.Cacher.
-// CommonCacher is universal to manage cache of any registry.
+// CommonCacher implements pkg.Cacher.
+// CommonCacher is universal to manage cache of any cache.
Review comment:
注释错了
##########
File path: datasource/etcd/sd/indexer_cache.go
##########
@@ -14,26 +14,26 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package discovery
+package sd
import (
"time"
+ "github.com/apache/servicecomb-service-center/datasource/etcd/client"
"github.com/apache/servicecomb-service-center/pkg/log"
"github.com/apache/servicecomb-service-center/pkg/util"
- "github.com/apache/servicecomb-service-center/server/plugin/registry"
"context"
)
-// CacheIndexer implements discovery.Indexer.
+// CacheIndexer implements pkg.Indexer.
Review comment:
注释错误
##########
File path: datasource/etcd/sd/indexer.go
##########
@@ -14,22 +14,22 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package discovery
+package sd
import (
- "github.com/apache/servicecomb-service-center/server/plugin/registry"
+ "github.com/apache/servicecomb-service-center/datasource/etcd/client"
"context"
)
// Indexer searches k-v data.
// An indexer may search k-v data from many data sources,
-// e.g. cache, registry, file, other Indexers...
+// e.g. cache, cache, file, other Indexers...
type Indexer interface {
// Search searches k-v data based on the input options
- Search(ctx context.Context, opts ...registry.PluginOpOption)
(*Response, error)
+ Search(ctx context.Context, opts ...client.PluginOpOption) (*Response,
error)
// Creditable judges whether Indexer's search results are creditable
- // It is recommended to use cache only and not to call the backend
+ // It is recommended to use cache only and not to call the cache
Review comment:
注释错误
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
