tianxiaoliang commented on a change in pull request #759:
URL:
https://github.com/apache/servicecomb-service-center/pull/759#discussion_r533101155
##########
File path: datasource/mongo/heartbeat/manager.go
##########
@@ -48,11 +49,11 @@ func Init(opts Options) error {
func New(opts Options) (HealthCheck, error) {
if opts.PluginImplName == "" {
- return nil, fmt.Errorf("plugin implement name is nil")
+ return nil, errors.New("plugin implement name is nil")
Review comment:
这些都抽成 var ErrXXX 请学习uber的go编程规范
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
