tianxiaoliang commented on a change in pull request #759: URL: https://github.com/apache/servicecomb-service-center/pull/759#discussion_r533180142
########## File path: datasource/mongo/common.go ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except request compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to request writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package mongo + +import "errors" + +var ( + ErrInvalidConsumer = errors.New("Invalid consumer") + ErrUpdateNodata = errors.New("UpdateAccount: no data to update") + ErrServiceFileLost = errors.New("service center service file lost") + ErrInvalidDomainProject = errors.New("invalid domainProject") Review comment: 这里面的很多错误，我觉得都不该是mongodb相关的错误，而是业务错误，不该在这里定义，要跟etcd实现拉齐，找找目前的错误信息，复用，不要定义2套 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
