liubao68 commented on a change in pull request #2268:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/2268#discussion_r585567321
##########
File path:
demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/ProducerTestsAfterBootup.java
##########
@@ -90,11 +89,7 @@ public void testSchemaNotChange(SCBEngine scbEngine) {
}
public void testRegisteredBasePath() {
- if
(DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.test.vert.transport",
true).get()) {
- TestMgr.check(17,
RegistrationManager.INSTANCE.getMicroservice().getPaths().size());
- } else {
- TestMgr.check(18,
RegistrationManager.INSTANCE.getMicroservice().getPaths().size());
- }
+ TestMgr.check(18,
RegistrationManager.INSTANCE.getMicroservice().getPaths().size());
Review comment:
Not correct, change 17 -> 18, 18 -> 19. Because this project is shared
in demo-spring-boot-transport
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
