liubao68 commented on a change in pull request #2268:
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/2268#discussion_r589145995



##########
File path: 
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/archaius/sources/ConfigCenterConfigurationSourceImpl.java
##########
@@ -147,5 +160,18 @@ public void handle(String action, Map<String, Object> 
parseConfigs) {
       }
       LOGGER.info("Config value cache changed: action:{}; item:{}", action, 
configuration.keySet());
     }
+
+    private void replaceConfig(Map<String, Object> configuration, String 
fileName) {
+      Object tempConfig = configuration.get(fileName);
+      configuration.remove(fileName);

Review comment:
       Seems remove fileName will cause update contents will not availale. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to