liubao68 commented on a change in pull request #2268:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/2268#discussion_r585569259
##########
File path:
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/archaius/sources/ConfigCenterConfigurationSourceImpl.java
##########
@@ -126,7 +128,23 @@ public void handle(String action, Map<String, Object>
parseConfigs) {
if (parseConfigs == null || parseConfigs.isEmpty()) {
return;
}
+
Map<String, Object> configuration =
ConfigMapping.getConvertedMap(parseConfigs);
+ List<String> fileSourceList = new ArrayList<>();
+
+ try {
+ fileSourceList = configCenterClient.getFileSources();
+ } catch (NullPointerException e) {
Review comment:
1. use IDE formatter in etc folder to format code
2. do not catch NullPointerException, figure out when NullPointerException
is thrown, and add null check .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
