FlorianHockmann commented on a change in pull request #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#discussion_r261872574
########## File path: docker/gremlin-server/Dockerfile.template ########## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +FROM tinkerpop:hadoop-HADOOP_VERSION Review comment: I haven't really looked into this image, but couldn't we use the gremlin-server image that we also publish to Docker Hub instead as a base image? This would have the nice advantage that we would use the image for testing that we are also publishing and we could also change the version to use an older image for the tests to test backwards compatibility. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
