FlorianHockmann commented on a change in pull request #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#discussion_r261871435
########## File path: docker/gremlin-server.sh ########## @@ -0,0 +1,55 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Build docker images first +# Build gremlin-server: mvn clean install -pl :gremlin-server -am + +DIR=`dirname $0` +PROJECT_HOME=${DIR}/../ + +TIMESTAMP=$(date +%s) +BUILD_TAG="gremlin-server-test-${TIMESTAMP}" + +function cleanup { + BUILD_IMAGE=$(docker images tinkerpop | awk "{if (\$2 == \"${BUILD_TAG}\") print \$3}") + [ ! -z ${BUILD_IMAGE} ] && docker rmi ${BUILD_IMAGE} + rm -f ${PROJECT_HOME}/Dockerfile +} +trap cleanup EXIT + +REMOVE_CONTAINER="--rm" +[[ -n ${KEEP_CONTAINER} ]] && unset REMOVE_CONTAINER + +pushd ${PROJECT_HOME} > /dev/null + +#mvn clean package -DskipTests=true -pl :gremlin-server || mvn clean install -pl :gremlin-server -am + +HADOOP_VERSION=$(cat pom.xml | grep -o '<hadoop.version>[^<]*' | head -n1 | cut -d '>' -f2) + +docker/build-containers.sh -h "${HADOOP_VERSION}" + +sed -e "s/HADOOP_VERSION\$/${HADOOP_VERSION}/" docker/gremlin-server/Dockerfile.template > Dockerfile + +docker build -t tinkerpop:${BUILD_TAG} . +docker run ${TINKERPOP_DOCKER_OPTS} ${REMOVE_CONTAINER} -ti tinkerpop:${BUILD_TAG} Review comment: I think it would make sense to use a different env var here instead of `TINKERPOP_DOCKER_OPTS`. My `TINKERPOP_DOCKER_OPTS` looks like this: ```bash $ echo $TINKERPOP_DOCKER_OPTS --tmpfs /usr/src/tinkermem:exec,mode=0755,rw,noatime,size=2000m -p 8080:80 ``` The port mapping is necessary on Windows to be able to access the generated docs on Windows as Docker for Windows unfortunately doesn't support connecting to a Docker container via its IP. This also means that I have to overwrite this env var now to: ```bash TINKERPOP_DOCKER_OPTS="-p 45940:45940" ``` to get the integration tests working with this image. If we would use a different env var here, then I (and possibly other contributors with Windows machines) could use this script and also still our usual `docker/build.sh` script :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
