FlorianHockmann commented on a change in pull request #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#discussion_r262050299
########## File path: docker/gremlin-server/Dockerfile.template ########## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +FROM tinkerpop:hadoop-HADOOP_VERSION Review comment: > What if you wanted to test 3.2.x server with a 3.4.x client? How do we access the test data from 3.2.x to copy it over? You mean if the test data is version specific and therefore won't work with a 3.2.z server if we are on `master`? I guess for that to work we would have to actually publish test images to Docker Hub that already contain the test data. But that should also be easier to do if we already use `tinkerpop/gremlin-server` here as the base image instead of building a completely new Gremlin Server image. > Finally, what would this look like? ./docker/gremlin-server.sh --version 3.2.9? Then without --version it uses the working copy? That sounds like a good idea to me, yes. It would make it possible to test different versions one after another by calling this script repeatedly with different versions. But being able to test older versions was really only a possibility I saw here. I don't think that we should tackle that with this PR. If we can simplify testing for the image built from the current branch, then that's already a great improvement in my opinion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
