xiazcy commented on code in PR #1788:
URL: https://github.com/apache/tinkerpop/pull/1788#discussion_r955311737
##########
gremlin-dotnet/test/pom.xml:
##########
@@ -62,52 +68,64 @@ limitations under the License.
</build>
<profiles>
+ <!-- Test gremlin-dotnet javascript in Docker -->
<profile>
- <id>gremlin-dotnet-standard</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <properties>
- <packaging.type>pom</packaging.type>
- </properties>
- </profile>
- <!-- activates the building of .NET components and requires that the
.NET SDK be installed on the system -->
- <profile>
- <id>gremlin-dotnet</id>
+ <id>glv-dotnet</id>
Review Comment:
It was renamed to be consistent with python, but yes, we probably should
leave that then so to not introduce API changes.
##########
gremlin-dotnet/test/pom.xml:
##########
@@ -62,52 +68,64 @@ limitations under the License.
</build>
<profiles>
+ <!-- Test gremlin-dotnet javascript in Docker -->
Review Comment:
This was missed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
