xiazcy commented on code in PR #1788:
URL: https://github.com/apache/tinkerpop/pull/1788#discussion_r955348267
##########
docker/gremlin-server/gremlin-server-integration.yaml:
##########
@@ -18,13 +18,15 @@
host: 0.0.0.0
port: 45940
evaluationTimeout: 30000
+channelizer: org.apache.tinkerpop.gremlin.server.channel.WsAndHttpChannelizer
graphs: {
- graph: conf/tinkergraph-empty.properties,
- classic: conf/tinkergraph-empty.properties,
- modern: conf/tinkergraph-empty.properties,
- crew: conf/tinkergraph-empty.properties,
- grateful: conf/tinkergraph-empty.properties,
- sink: conf/tinkergraph-empty.properties
+ graph: scripts/tinkergraph-empty.properties,
Review Comment:
It is because there is a difference between the
`tinkergraph-empty.properties` file in the `conf/` and the `script/` folders.
The `conf/` folder holds the default Gremlin Server set up, and the `script/`
folder holds the test server set up (it is under the Gremlin Server `test/`
folder).
Javascript tests needed the file from `scripts` folder where the
`vertexIdManager` is set to INTEGER, and we wanted to reuse this server yaml
file, so it was changed here.
Would you foresee problems with changing this file? I'm not sure if there
was a particular reason for default to be different, perhaps that's also
something to look into next.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
