xiazcy commented on code in PR #1788:
URL: https://github.com/apache/tinkerpop/pull/1788#discussion_r959941245
##########
gremlin-dotnet/test/pom.xml:
##########
@@ -161,192 +179,10 @@ limitations under the License.
</scripts>
</configuration>
</execution>
- <execution>
- <id>gremlin-server-start</id>
- <phase>pre-integration-test</phase>
- <goals>
- <goal>execute</goal>
- </goals>
- <configuration>
- <properties>
- <property>
- <name>skipTests</name>
- <value>${skipTests}</value>
- </property>
- <property>
- <name>gremlinServerDir</name>
-
<value>${gremlin.server.dir}</value>
- </property>
- <property>
- <name>settingsFile</name>
-
<value>${gremlin.server.dir}/src/test/resources/org/apache/tinkerpop/gremlin/server/gremlin-server-integration.yaml</value>
- </property>
- <property>
- <name>executionName</name>
- <value>${project.name}</value>
- </property>
- <property>
- <name>projectBaseDir</name>
- <value>${project.basedir}</value>
- </property>
- <property>
- <name>tinkerpopRootDir</name>
-
<value>${tinkerpop.root.dir}</value>
- </property>
- </properties>
- <scripts>
-
<script>${gremlin.server.dir}/src/test/scripts/test-server-start.groovy</script>
- </scripts>
- </configuration>
- </execution>
- <execution>
- <id>gremlin-server-stop</id>
- <phase>post-integration-test</phase>
- <goals>
- <goal>execute</goal>
- </goals>
- <configuration>
- <properties>
- <property>
- <name>skipTests</name>
- <value>${skipTests}</value>
- </property>
- <property>
- <name>executionName</name>
- <value>${project.name}</value>
- </property>
- </properties>
- <scripts>
-
<script>${gremlin.server.dir}/src/test/scripts/test-server-stop.groovy</script>
- </scripts>
- </configuration>
- </execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
- <!--
- This profile will include neo4j for purposes of transactional
testing within Gremlin Server.
- Tests that require neo4j specifically will be "ignored" if this
profile is not turned on.
- -->
- <profile>
- <id>include-neo4j</id>
- <activation>
- <activeByDefault>false</activeByDefault>
- <property>
- <name>includeNeo4j</name>
Review Comment:
Removed flags from .NET and Javascript GHA in
[a25300b](https://github.com/apache/tinkerpop/pull/1788/commits/a25300b27cfbf949826ea810dc10059aa7e43f8d)
##########
.github/workflows/build-test.yml:
##########
@@ -141,20 +174,41 @@ jobs:
javascript:
name: javascript
timeout-minutes: 15
- needs: smoke
+ needs: cache-gremlin-server-docker-image
runs-on: ${{ matrix.os }}
strategy:
matrix:
- os: [ubuntu-latest, windows-latest]
+ # Windows Disabled until Linux containers are supported on Windows
runners: https://github.com/actions/virtual-environments/issues/252
+ # os: [ubuntu-latest, windows-latest]
+ os: [ubuntu-latest]
steps:
- uses: actions/checkout@v3
- name: Set up JDK 11
uses: actions/setup-java@v3
with:
java-version: '11'
distribution: 'temurin'
+ - name: Get Cached Server Base Image
+ if: matrix.os == 'ubuntu-latest'
+ uses: actions/cache@v3
+ id: gremlin-server-test-docker-image
+ with:
+ path: |
+ ./gremlin-server/*
+ ~/.m2/repository/org/apache/tinkerpop/*
+ key: ${{ github.sha }}
+ - name: Download Server Base Image
+ if: matrix.os == 'windows-latest'
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
