xiazcy commented on code in PR #1788:
URL: https://github.com/apache/tinkerpop/pull/1788#discussion_r965370689
##########
gremlin-dotnet/test/pom.xml:
##########
@@ -115,16 +116,29 @@ limitations under the License.
</goals>
<configuration>
<skip>${skipTests}</skip>
- <environmentVariables>
-
<GREMLIN_SERVER>${project.version}</GREMLIN_SERVER>
- <HOME>${user.home}</HOME>
- </environmentVariables>
+ <!-- don't need to set env variables for
container tear down -->
<executable>docker-compose</executable>
<arguments>
<argument>down</argument>
</arguments>
</configuration>
</execution>
+ <execution>
+ <id>remove-dangling-images</id>
+ <phase>integration-test</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <skip>${skipTests}</skip>
+ <executable>docker</executable>
+ <arguments>
+ <argument>image</argument>
+ <argument>prune</argument>
Review Comment:
I added a label filter option so that the dangling images we prune are only
ones we created with the label "[email protected]" in
[f92df86](https://github.com/apache/tinkerpop/pull/1788/commits/f92df86bb0533dfd9f95dfbe3f3b2875439b9af3).
This should make sure we don't touch the other ones on the machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
