spmallette commented on code in PR #1788:
URL: https://github.com/apache/tinkerpop/pull/1788#discussion_r961865878
##########
docker/gremlin-server/gremlin-server-integration.yaml:
##########
@@ -18,13 +18,15 @@
host: 0.0.0.0
port: 45940
evaluationTimeout: 30000
+channelizer: org.apache.tinkerpop.gremlin.server.channel.WsAndHttpChannelizer
graphs: {
- graph: conf/tinkergraph-empty.properties,
- classic: conf/tinkergraph-empty.properties,
- modern: conf/tinkergraph-empty.properties,
- crew: conf/tinkergraph-empty.properties,
- grateful: conf/tinkergraph-empty.properties,
- sink: conf/tinkergraph-empty.properties
+ graph: scripts/tinkergraph-empty.properties,
Review Comment:
> So I'm wondering if we want to leave this issue alone for now, and just
created a conf/tinkergraph-service.properties with
gremlin.tinkergraph.vertexIdManager=INTEGER for javascript?
yes, just keep the config as it is but rename the file.
separately, please create an issue in JIRA with your findings about
Javascript. i assume the fix would be to properly generate Javascript to use
`toLong()` somehow:
https://github.com/apache/tinkerpop/blob/624cfe87e275fe0d6dba710288471cc5b52c93f8/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/utils.js#L28-L30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
