xiazcy commented on code in PR #1788:
URL: https://github.com/apache/tinkerpop/pull/1788#discussion_r965277351
##########
gremlin-dotnet/test/pom.xml:
##########
@@ -115,16 +116,29 @@ limitations under the License.
</goals>
<configuration>
<skip>${skipTests}</skip>
- <environmentVariables>
-
<GREMLIN_SERVER>${project.version}</GREMLIN_SERVER>
- <HOME>${user.home}</HOME>
- </environmentVariables>
+ <!-- don't need to set env variables for
container tear down -->
<executable>docker-compose</executable>
<arguments>
<argument>down</argument>
</arguments>
</configuration>
</execution>
+ <execution>
+ <id>remove-dangling-images</id>
+ <phase>integration-test</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <skip>${skipTests}</skip>
+ <executable>docker</executable>
+ <arguments>
+ <argument>image</argument>
+ <argument>prune</argument>
Review Comment:
So the [docker image
prune](https://docs.docker.com/config/pruning/#prune-images) will only remove
the dangling images on the machine. By definition they are old images that
becomes untagged when you create a new version and no longer serve a purpose
and consume disk space.
Currently, we do the container removal with `docker compose down` and keep
all tagged images on the machine.
Typically dangling images are safe to remove, but I will look into ways to
remove only dangling images related to our build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
