kmcginnes commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1970178605
I've reviewed through the code and it looks great overall. Nice work @tien. I called out a few areas of potential concern that could use some attention. It would also be nice to have some automated tests that execute within the context of a browser to ensure we don't regress in the future. Perhaps [Playwright](https://playwright.dev/) can help with this. This is likely to be a large task, so we might want to do it as a separate set of work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
