kenhuuu commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1972243401
You are targetting this PR against the master branch which is currently for the next major release (4.0). The way our branching system works is that you target the lowest version that you want the change to go into. Then when your PR gets merged, the committer will merge your changes all the way up to the latest master branch. It's a bit difficult to explain so I'll use an example. If you want your changes to go into the next 3.6.x, 3.7.x and 4.x release, then you would target the 3.6-dev branch and it will get merged up for you. If you target master then it will only go into the next 4.x release. I say this because I believe that currently there is no timeline for releasing 4.0 as we are doing releases for 3.6.x and 3.7.x. So if you were to target master then you may need to wait for a while for this change to get released. However, because its currently targetting an unreleased branch, you are technically allowed to upgrade the Node version and ES version. So, do you prefer to wait for this change to arrive in 4.x? In which case, you can make Node and ES version changes. Or, if you want it released sooner then you will probably have to undo your changes to ESLint and target the 3.7-dev branch as some of those changes could be considered breaking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
