tien commented on code in PR #2506:
URL: https://github.com/apache/tinkerpop/pull/2506#discussion_r1508361689
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/client-behavior-tests.js:
##########
@@ -21,58 +21,56 @@
const assert = require('assert');
const helper = require('../helper');
-const {getUserAgent} = require("../../lib/utils");
+const { getUserAgent } = require('../../lib/utils');
let client;
let settings;
describe('Client', function () {
- before(function () {
- client = helper.getGremlinSocketServerClient('gmodern');
- settings = helper.getGremlinSocketServerSettings();
- return client.open();
- });
- after(function () {
- return client.close();
- });
- describe('#submit()', function () {
- it('should reconnect after server closes connection', async function
() {
- let connectionClosed = false;
- await client.submit('1', null, {requestId:
settings.CLOSE_CONNECTION_REQUEST_ID})
- .catch(function(error){
- assert.equal(error.toString(), 'Error: Connection has been
closed.');
- connectionClosed = true;
- });
+ before(function () {
Review Comment:
Yes, this is from prettier formatting. I've got my editor setup to
automatically format on save if the project have prettier setted up, which is
project have. I think it's a good idea to enforce formatting rule, even on CI.
But if an exception should be made for the test files, should I add all test
files to `.prettierignore` then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
