spmallette commented on code in PR #2919:
URL: https://github.com/apache/tinkerpop/pull/2919#discussion_r1868216598
##########
spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/SparkGraphFeatureIntegrateTest.java:
##########
@@ -162,6 +162,11 @@ private static Map<String, Object>
getBaseConfiguration(final GraphData graphDat
put(Constants.SPARK_KRYO_REGISTRATION_REQUIRED, true);
}};
}
+
+ @Override
+ public boolean useParametersLiterally() {
+ return false;
Review Comment:
as noted for TinkerGraph, I feel like we need to test both configurations
because we want to test `GValue` (when this is "false") and straight
translation (when this is "true"). feels like we're leaving something out by
not having both configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
