Cole-Greer commented on code in PR #2919: URL: https://github.com/apache/tinkerpop/pull/2919#discussion_r1868690669
########## neo4j-gremlin/src/test/java/org/apache/tinkerpop/gremlin/neo4j/Neo4jGraphFeatureTest.java: ########## @@ -50,7 +50,7 @@ @RunWith(Cucumber.class) @CucumberOptions( - tags = "not @RemoteOnly and not @MultiProperties and not @MetaProperties and not @GraphComputerOnly and not @AllowNullPropertyValues and not @UserSuppliedVertexPropertyIds and not @UserSuppliedEdgeIds and not @UserSuppliedVertexIds and not @TinkerServiceRegistry", + tags = "not @RemoteOnly and not @MultiProperties and not @MetaProperties and not @GraphComputerOnly and not @AllowNullPropertyValues and not @UserSuppliedVertexPropertyIds and not @UserSuppliedEdgeIds and not @UserSuppliedVertexIds and not @TinkerServiceRegistry and not @StepHasId", Review Comment: There are 2 scenarios which are currently failing with Neo4j (`g_V_hasIdXemptyX_count` and `g_V_hasIdXwithinXemptyXX_count`). Neo4j appears to be letting all vertices pass with `hasId([])` whereas TinkerGraph is filtering all vertices. I opted to ignore in this case as TinkerGraph is working as expected, and the future of Neo4j-gremlin is up in the air at the moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
