Cole-Greer commented on code in PR #2919:
URL: https://github.com/apache/tinkerpop/pull/2919#discussion_r1868693912


##########
spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/SparkGraphFeatureIntegrateTest.java:
##########
@@ -162,6 +162,11 @@ private static Map<String, Object> 
getBaseConfiguration(final GraphData graphDat
                 put(Constants.SPARK_KRYO_REGISTRATION_REQUIRED, true);
             }};
         }
+
+        @Override
+        public boolean useParametersLiterally() {
+            return false;

Review Comment:
   I opted to leave Spark and Hadoop with the single configuration as these 
suites are quite slow to run and I don't see much value in running both 
configurations. I can make the change if you believe the added coverage is 
needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to