andreachild commented on code in PR #3091:
URL: https://github.com/apache/tinkerpop/pull/3091#discussion_r2034180141
##########
gremlin-language/src/main/antlr4/Gremlin.g4:
##########
@@ -22,6 +22,12 @@ grammar Gremlin;
PARSER RULES
**********************************************/
+gremlinValue
+ : (numericLiteral | booleanLiteral | stringLiteral | dateLiteral |
nullLiteral | nanLiteral | infLiteral |
+ traversalT | traversalCardinality | traversalDirection | traversalMerge
|
+ structureVertex | genericLiteralSet | genericLiteralCollection |
genericLiteralMap) EOF
Review Comment:
To exclude traversals and other non-paramterizables would it make sense to
create separate `gremlinValueSet`, `gremlinValueCollection`, `gremlinValueMap`
instead of using the `genericLiteralX` rules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
