andreachild commented on code in PR #3091:
URL: https://github.com/apache/tinkerpop/pull/3091#discussion_r2034192178
##########
gremlin-language/src/main/antlr4/Gremlin.g4:
##########
@@ -67,34 +73,34 @@ traversalSourceSelfMethod
;
traversalSourceSelfMethod_withBulk
- : 'withBulk' LPAREN booleanArgument RPAREN
+ : K_WITHBULK LPAREN booleanArgument RPAREN
;
traversalSourceSelfMethod_withPath
- : 'withPath' LPAREN RPAREN
+ : K_WITHPATH LPAREN RPAREN
;
traversalSourceSelfMethod_withSack
- : 'withSack' LPAREN genericLiteralArgument RPAREN
- | 'withSack' LPAREN genericLiteralArgument COMMA
traversalBiFunctionArgument RPAREN
+ : K_WITHSACK LPAREN genericLiteralArgument RPAREN
+ | K_WITHSACK LPAREN genericLiteralArgument COMMA traversalBiFunction RPAREN
;
traversalSourceSelfMethod_withSideEffect
- : 'withSideEffect' LPAREN stringArgument COMMA genericLiteralArgument
RPAREN
- | 'withSideEffect' LPAREN stringArgument COMMA genericLiteralArgument
COMMA traversalBiFunctionArgument RPAREN
+ : K_WITHSIDEEFFECT LPAREN stringArgument COMMA genericLiteralArgument
RPAREN
+ | K_WITHSIDEEFFECT LPAREN stringArgument COMMA genericLiteralArgument
COMMA traversalBiFunction RPAREN
Review Comment:
Is the replacement of `traversalBiFunctionArgument` with
`traversalBiFunction` backwards compatible? The `traversalBiFunctionArgument`
(prior to its deletion in this PR) used to allow `variable` but
`traversalBiFunction` does not.
```
traversalBiFunctionArgument
: traversalBiFunction
| variable
;
```
```
traversalBiFunction
: traversalOperator
;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
